Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@extends output missing selector when using same name for tag and attribute #2347

Closed
jlowcs opened this issue Mar 7, 2017 · 2 comments
Closed

Comments

@jlowcs
Copy link

jlowcs commented Mar 7, 2017

@extends output missing selector when using same name for tag and attribute

There is a strange issue when using @extend on a selector with a tag name and an attribute name with the same name: the second one is absent from the output.

input.scss

%baz2 {
    display: flex;
}
%baz3 {
    display: flex;
}

custom2, [custom2], .custom2 {
    @extend %baz2
}

[custom3], custom3, .custom3 {
    @extend %baz3
}

libsass 3.5.0.beta.3

custom2, .custom2 {
  display: flex; }

[custom3], .custom3 {
  display: flex; }

Same result on http://sass.js.org/

version info:

$ node-sass --version
node-sass       4.5.0   (Wrapper)       [JavaScript]
libsass         3.5.0.beta.2    (Sass Compiler) [C/C++]

Expected:

custom2, [custom2], .custom2 {
  display: flex;
}

[custom3], custom3, .custom3 {
  display: flex;
}

Spec sass/sass-spec#1091

@xzyfer
Copy link
Contributor

xzyfer commented Mar 21, 2017

#2350 only partially addressed this issue.

Before

-custom2, [custom2], .custom2 {
+custom2, .custom2 {
   display: flex;
 }
-[custom3], custom3, .custom3 {
+[custom3], .custom3 {
   display: flex;
 }

After

-custom2, [custom2], .custom2 {
+custom2, .custom2 {
   display: flex;
 }
 [custom3], custom3, .custom3 {

@mgreter
Copy link
Contributor

mgreter commented Mar 30, 2017

Fixed by #2354

@mgreter mgreter closed this as completed Mar 30, 2017
xzyfer added a commit to sass/sass-spec that referenced this issue Mar 30, 2017
xzyfer added a commit to sass/sass-spec that referenced this issue Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants