Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String Interpolation incorrectly quoted when used as parent selector #1770

Closed
petebrowne opened this issue Dec 2, 2015 · 3 comments
Closed

Comments

@petebrowne
Copy link

Input SCSS:

@function returns-string() {
  @return "selector";
}

#{"selector"} {
  color: red;
}

#{returns-string()} {
  color: red;
}

#{"selector"} selector2 {
  color: red;
}

#{returns-string()} selector2 {
  color: red;
}

Ruby Sass output:

selector {
  color: red; }

selector {
  color: red; }

selector selector2 {
  color: red; }

selector selector2 {
  color: red; }

Libsass (via node-sass)

selector {
  color: red; }

selector {
  color: red; }

selector selector2 {
  color: red; }

"selector" selector2 {
  color: red; }
@xzyfer
Copy link
Contributor

xzyfer commented Dec 3, 2015

Thanks for the report @petebrowne. I can confirm this issue is present on master.

xzyfer added a commit to xzyfer/sass-spec that referenced this issue Dec 3, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Dec 3, 2015

Spec added sass/sass-spec#638

@xzyfer
Copy link
Contributor

xzyfer commented Dec 31, 2015

This is fixed and will be in the upcoming 3.3.3. Subscribe to #1808 for future updates on that release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants