-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libsass to fix materializecss crash #149
Conversation
We don't do unstable releases any more, but I will release a version targeting 3.3.6 when I get home :) |
I was concerned about that, its nice 3.3.6 covers that PR. I amended the PR and tested it at the 3.3.6 tag. |
The appveyor failure is strange... I wonder if they broke something upstream. (I'm on my phone or I'd debug it) |
I can't re-run the build. |
@asottile can you rerun the build and see if its not a fluke? |
Weird, I don't have permission for some reason -- you can retrigger a build with a trivial amend:
I have a feeling this is a real failure -- I've started debugging it locally |
This fixes a segfault that happens while compiling materializecss. Its tested with https://github.com/torchbox/django-libsass The bug is documented on the libsass website at sass/libsass#1960 The patch was merge upstream at sass/libsass#2032.
Good idea, for me it'd be |
It crashes for me locally as well -- but only for 64bit python3.5 -- I'll dig into this further |
Ok, this PR is just an update, if you have something, feel free to close this. |
I'm trying to bisect when things go wrong. From some googling it appears to be a stack overrun and it only seems to happen in error cases (and curiously only on python3.5-64 -- maybe that means it's our code's fault somehow?). |
This seems to be the first commit which triggers this strange behaviour: sass/libsass@527f3a8 |
Created sass/libsass#2046 with a reproduction which doesn't involve python |
@tony looks like we figured it out :) sass/libsass#2046 sass/libsass#2048 I think we'll be skipping 3.3.6 and going straight to 3.3.7 when that comes out Thanks for the PR though, sorry it didn't work out due to other reasons :) |
Ok awesome. I see what was happening there |
upstream 3.3.6 is now available as 0.11.2! ✨ |
I know you just tagged a release. There is a fix effecting people with https://github.com/Dogfalo/materialize that only got merged in within the last 24 hours.
This fixes a segfault that happens while compiling materializecss.
Its tested with https://github.com/torchbox/django-libsass
The bug is documented on the libsass website at
sass/libsass#1960
The patch was merge upstream at
sass/libsass#2032.