Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include generated classes in pub.dev releases #2047

Closed
doodlezucc opened this issue Jul 30, 2023 · 1 comment · Fixed by #2048 or #2050
Closed

Include generated classes in pub.dev releases #2047

doodlezucc opened this issue Jul 30, 2023 · 1 comment · Fixed by #2048 or #2050
Assignees

Comments

@doodlezucc
Copy link

Hi there, I've noticed that it's not possible anymore to compile the latest sass executables via dart pub global activate sass. Using sass as a dev dependency in a Dart project yields similar compile/analysis errors. Essentially, the file embedded_sass.pb.dart can't be found.

I've tried compiling from source by following your instructions, and naturally all analysis errors got resolved after generating the files for the embedded compiler with Buf.

According to the pub.dev page, static analysis has been failing since version 1.63.1, which introduced the embedded compiler into the repo. I understand that best practice suggests adding generated files to .gitignore, but would it be possible to include the .pg*.dart files for pub.dev publication?

It's definitely not the standard way to use sass CLI, but as a Dart user myself, it's pretty convenient to simply activate the package from pub. My apologies if this issue has been brought up before, I wasn't able to find anyone mentioning it in this repository.

@nex3
Copy link
Contributor

nex3 commented Aug 1, 2023

Looks like the definitions are still missing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants