Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo doc #12

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix cargo doc #12

merged 2 commits into from
Jan 11, 2024

Conversation

micwoj92
Copy link
Contributor

-MessageHeader has been renamed to HasJobId

-tokio-util crate feature codec is needed to be enabled

error[E0432]: unresolved import `tokio_util::codec`
  --> crates/steam-client/src/connection/mod.rs:23:17

-Allowed unaligned_references, but ideally this should be fixed
rust-lang/rust#82523

@evanjs
Copy link

evanjs commented Apr 16, 2023

Thank you
cargo doc now suceeds when using this PR
Building steam-client indeed still fails, as mentioned.

@micwoj92
Copy link
Contributor Author

@evanjs what error do you get when building? It works for me, with warnings.

@micwoj92
Copy link
Contributor Author

micwoj92 commented Dec 3, 2023

I guess i was lucky enough I checked this with rust version that didn't make this hard error. I have removed this "workaround" and updated pr title.

@micwoj92 micwoj92 changed the title Fix build errors in steam-client Fix cargo doc Dec 3, 2023
@micwoj92
Copy link
Contributor Author

micwoj92 commented Dec 3, 2023

@saskenuba could you look at this and #14 ?

@saskenuba
Copy link
Owner

@saskenuba could you look at this and #14 ?

Sorry for the wait — As soon as I finish the login update in steam-mobile I'll dive into this.

Thanks a bunch!

@saskenuba saskenuba self-assigned this Jan 10, 2024
@saskenuba
Copy link
Owner

Thanks @micwoj92. Merging.

@saskenuba saskenuba merged commit 208a6ad into saskenuba:master Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants