feat: Support Delete Message API #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kappa-lab
changed the title
kappa-lab
force-pushed
the
feature/delete_message
branch
from
2569761
to
0bdc97a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #799 +/- ##
==========================================
+ Coverage 98.46% 99.01% +0.55%
==========================================
Files 24 26 +2
Lines 1364 1418 +54
==========================================
+ Hits 1343 1404 +61
+ Misses 15 8 -7
Partials 6 6 ☔ View full report in Codecov by Sentry. |
kappa-lab
force-pushed
the
feature/delete_message
branch
from
0bdc97a
to
4dc6f68
Compare
kappa-lab
commented
Jul 19, 2024
messages_test.go
Outdated
| "github.com/sashabaranov/go-openai/internal/test/checks" | ||
| ) | ||
|
|
||
| var emptyStr = "" | ||
|
|
||
| // TestMessages Tests the messages endpoint of the API using the mocked server. | ||
| func TestMessages(t *testing.T) { | ||
| func registerServer(t *testing.T, server *test.ServerTest) { |
There was a problem hiding this comment.
split func for linter
There was a problem hiding this comment.
The registerServer name is very generic, let's name it with something more concrete for this test
There was a problem hiding this comment.
rename to setupServerForTestMessage
8facd6e
nolint : Deprecated method split function: cognitive complexity 21
kappa-lab
force-pushed
the
feature/delete_message
branch
from
447cb85
to
5404aaa
Compare
|
Thank you for the PR! Added a minor comment |
kappa-lab
force-pushed
the
feature/delete_message
branch
from
8737c46
to
8facd6e
Compare
sashabaranov
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
OpenAI documentation
relevant API doc from https://platform.openai.com/docs/api-reference/messages/deleteMessage
Additional context