Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CreateFile support io.Reader #622

Closed
wants to merge 2 commits into from
Closed

feat: CreateFile support io.Reader #622

wants to merge 2 commits into from

Conversation

eiixy
Copy link
Contributor

@eiixy eiixy commented Dec 21, 2023

Issue: #581

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f10955c) 98.44% compared to head (9b13b47) 98.08%.

Files Patch % Lines
files.go 66.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   98.44%   98.08%   -0.36%     
==========================================
  Files          24       24              
  Lines        1354     1361       +7     
==========================================
+ Hits         1333     1335       +2     
- Misses         15       19       +4     
- Partials        6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdullah2993
Copy link

would be nice if this one gets merged. It follow the same api as AudioRequest

@eiixy eiixy closed this by deleting the head repository May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants