Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 new request attribute mappings for TYPO3 v13 #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@sascha-egerer
Copy link
Owner

We still need a way to make this TYPO3 version dependent as these types are now also valid in older TYPO3 versions with the current implementation.

@derhansen
Copy link
Contributor Author

Can you elaborate what this means for this PR? Should we have different versions of the package for different TYPO3 versions or make requestGetAttributeMapping somehow TYPO3 major version aware? IMO, it would be fine to just add the types as is, since they just provide type mapping for the static code analysis and I doubt developers will use v13 only request attributes in <v13 projects.

But I'm also fine to just add the mapping to my custom phpstan.neon file :-)

@sascha-egerer
Copy link
Owner

I'm not yet sure how to solve the issue with supporting multiple TYPO3 versions. We do also have issues with the stubs where we already have a way to load them based on the TYPO3 version. But we really have to clean this up. I'll try to have a look at it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants