Add support for PHPStan 1.11 #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-egerer
force-pushed
the
phpstan-1.11
branch
from
dac2ed3
to
4dbe17a
Compare
oliverklee
reviewed
May 13, 2024
| @@ -12,7 +12,7 @@ | |||
| "prefer-stable": true, | |||
| "require": { | |||
| "php": "^7.4 || ^8.0", | |||
| "phpstan/phpstan": "^1.10.9", | |||
| "phpstan/phpstan": "^1.10.9 || ^1.11.0", | |||
There was a problem hiding this comment.
^1.10.9 already includes 1.11.*, while ~1.10.9 would not. Or am I missing something here?
There was a problem hiding this comment.
Nope, your're right. My fault.
I'm just thinking about how to handle the package version now if it's compatible with 1.10 and 1.11. The package version was always not based on semantic versioning but the PHPStan version it is based on. But here was no breaking change form 1.10 to 1.11 this time. So IMO there is no need to change the package version but it looks now "outdated" if we keep 1.10. It just feels weird...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.