Add more precise return type for Repository::setDefaultOrderings()

sascha-egerer · Aug 9, 2024 · 5d380d7 · 5d380d7
1 parent b56227c
commit 5d380d7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/stubs/QueryInterface.stub b/stubs/QueryInterface.stub
@@ -6,6 +6,11 @@ namespace TYPO3\CMS\Extbase\Persistence;
  */
 interface QueryInterface
 {
+    // We have to define the constants here to be able to use them in other stubs.
+    // See https://phpstan.org/user-guide/stub-files
+    public const ORDER_ASCENDING = 'ASC';
+    public const ORDER_DESCENDING = 'DESC';
+
     /**
      * @param bool $returnRawQueryResult
      * @return \TYPO3\CMS\Extbase\Persistence\QueryResultInterface<ModelType>|list<array<string, mixed>>

diff --git a/stubs/Repository.stub b/stubs/Repository.stub
@@ -47,7 +47,7 @@ class Repository
     public function findByIdentifier($identifier);
 
     /**
-     * @phpstan-param array<non-empty-string, non-empty-string> $defaultOrderings
+     * @phpstan-param array<non-empty-string, QueryInterface::ORDER_*> $defaultOrderings
      * @phpstan-return void
      */
     public function setDefaultOrderings($defaultOrderings);