fixes powerschool showing icons next to every assignment #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
|
@ARtheboss this should fix the issue, can you test as well? |
gary-kim
reviewed
Apr 26, 2021
src/js/helpers.js
Outdated
| @@ -203,7 +203,8 @@ function assignments (node) { | |||
| [...node.querySelector('table[align=center').querySelectorAll('tr')].slice(1, -1).forEach((e, i) => { | |||
| const curr = e.querySelectorAll('td'); | |||
| const assignment = new Assignment(curr[2]?.innerText || "", curr[curr.length - 1]?.innerText || "", i); | |||
| if (e.querySelector('img[src="/images/icon_missing.gif"]')) { | |||
| const missingIcon = e.querySelector('img[src="/images/icon_missing.gif"]'); | |||
| if (missingIcon && missingIcon.style.display !== 'none') { | |||
There was a problem hiding this comment.
You can simply this to the following, actually:
Suggested change
| if (missingIcon && missingIcon.style.display !== 'none') { | |
| if (missingIcon?.style.display !== 'none') { |
There was a problem hiding this comment.
I don't think this actually works here as for some classes this will be null due to inconsistent CSS(some classes don't contain the missingicon gif and some do), and as such it should be counted as not missing if it doesn't exist.
gary-kim
approved these changes
Apr 26, 2021
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
ARtheboss
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accounts for recent PowerSchool change where some courses have the missing icon in the HTML hidden.
fixes #275
Signed-off-by: Suhas Hariharan hariharan774531@sas.edu.sg