Fix CI: Pin Black version for linting #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Black 24.1.0 has updated the formatting style and it changes several things in the resolvelib codebase: https://github.com/psf/black/releases/tag/24.1.0
In providers.py it changes:
To:
Which fails the flake8 rule "E704 multiple statements on one line (def)". I am therefore pinning the black version so it does not impact other PRs, and does not fight with flake8. Also in general it makes sense to pin your formatting tool so these breakages don't happen.
I'd also be happy to do a follow up PR that moves the linting and formatting config to
ruff
if the resolvelib maintainers view this as a good idea.