Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #481

Merged
merged 57 commits into from
Mar 20, 2024
Merged

Refactor #481

merged 57 commits into from
Mar 20, 2024

Conversation

sarub0b0
Copy link
Owner

@sarub0b0 sarub0b0 commented Mar 17, 2024 •
edited
Loading

  • modify module hierarchy, rename
  • package by feature
  • exclude files in the package section of Cargo.toml
  • use thread::scope

@sarub0b0 sarub0b0 marked this pull request as draft March 17, 2024 16:29
@sarub0b0 sarub0b0 force-pushed the refactor branch 2 times, most recently from 23f50c9 to c9815b7 Compare March 18, 2024 12:38
sarub0b0 and others added 25 commits March 19, 2024 02:36
@sarub0b0
refactor: config.rs to cmd module
11ececb
@sarub0b0
refactor: implement UserInput structure
89f26c0
@sarub0b0
refactor: move event/input.rs to workers/user_input.rs
3c10ba5
@sarub0b0
refactor: remove self:: from main.rs
946138c
@sarub0b0
refactor: move event/tick.rs to workers/tick.rs
e054176
@sarub0b0
refactor: add set_panic_hook to UserInput
193460f
@sarub0b0
refactor: add Tick structure
344dfba
@sarub0b0
refactor: use thread::sleep instead of crossbeam::channel::tick
78e8ac5
@sarub0b0
refactor: move event/kubernetes to workers/kubernetes
fbb83ac
@sarub0b0
refactor: rename clipboard_wrapper.rs to clipboard.rs
3a395d2
@sarub0b0
refactor: rename kubernetes to kube
aa959a0
@sarub0b0
chore: update csell.json
086f85b
@sarub0b0
refactor(kube): implment start method for kube worker
4a2994b
@sarub0b0
fix: fix logger! macro in workers
36453fd
@sarub0b0
refactor: move render logic to workers/render.rs
735c9b9
@sarub0b0
refactor: use thread::scope to spawn threads
0efa34c
@sarub0b0
refactor: rename event.rs to message.rs
1040449
@sarub0b0
refactor: remove unused code
e7933e8
@sarub0b0
refactor: move run function to app.rs
078c2e8
@sarub0b0
refactor: move signal_handler to main
1a04811
@sarub0b0
refactor: remove error module and use anyhow
c92aa72
@sarub0b0
refactor(pod): package by feature
873b77c
@sarub0b0
chore: update cspell.json
165887f
@sarub0b0
refactor(config): package by feature
c9384b8
@sarub0b0
refactor(network): move network feature to package-by-feature
8375002
@sarub0b0
refactor(yaml_popup): package by feature
72d3fb6
@sarub0b0
refactor(yaml): move fetch_resource_yaml to private
6086ebe
@sarub0b0
refactor(kube): move yaml::kube::direct to features::get
8a19798
@sarub0b0
fix(pod): fix typo in pod_watcher
289492e
@sarub0b0
refactor(kube): move workers::kube::{client,v1_table,metric_type} and…
2057099 
… table related code to kube module
@sarub0b0
refactor(api_resources): remove unused Set variant from ApiResponse
0f56f72
@sarub0b0
chore: set allow(dead_code) for all modules
33008a9
@sarub0b0
refactor: clippy
6673d2e
@sarub0b0
refactor(kube): rename poller structures.
8072550 
* PollWorker -> PollerBase
* Poller -> PollWorker
* MainWorker -> EventController
@sarub0b0
refactor(kube): move kube_store to store.rs
4580d8c
@sarub0b0
refactor(kube): remove unused KubeList and KubeListItem structs
7cd47cf
@sarub0b0
refactor(kube): move EventController to controller.rs
04f9abe
@sarub0b0
refactor(kube): move Kube message to message.rs
0298b89
@sarub0b0
refactor(kube): rename, reorganize and refactor kube module
60fedd6
@sarub0b0
refactor(kube): move context to kube module
c7ca780
@sarub0b0
refactor: rename WindowEvent to WindowAction
39d5fb0
@sarub0b0
refactor: rename EventResult::Window to EventResult::WindowAction
7ed92e8
@sarub0b0
refactor: remove Option from Callback, and move exec_to_window_event …
bd08323 
…to exec_callback
@sarub0b0
refactor: use trait alias for Callback
731041c
@sarub0b0
refactor: remove unnecessary else if in Window::on_mouse_event
3a193cf
@sarub0b0
refactor: use define_callback macro for callback definition
7c04470
@sarub0b0
refactor: Move view_id to component_id
fe68401
@sarub0b0
refactor(render): Move action module into render
1bfaf0c
@sarub0b0
refactor(action): Optimize exec_callback function
ecb8602 
The exec_callback function has been refactored to use a loop instead of
recursion when handling callbacks. This change improves the readability
of the code by making the control flow more explicit, and potentially
improves performance by avoiding the overhead of recursive function calls.
@sarub0b0
refactor(render): Move window module into render
3cc3e29
@sarub0b0 sarub0b0 marked this pull request as ready for review March 20, 2024 14:07
@sarub0b0 sarub0b0 merged commit 4f103af into main Mar 20, 2024
1 check passed
@sarub0b0 sarub0b0 deleted the refactor branch March 20, 2024 14:07
@sarub0b0 sarub0b0 mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sarub0b0