Various fixes as I attempted to get our CR-Connect application working against the lastest SpiffWorkflow build #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
danfunk
commented
Oct 7, 2022
danfunk
commented
- spec_type should be the type only, and should not reflect event defitions ('End Event' not 'Default End Event')
- MultInstance functions as a mixin, and should not overwrite the spec_type, a repeating User Task is still a User Task
- We implemented "Did you mean ..." twice - and with the latest changes to the PythonScriptEngine.py and DMNEngine.py, we can do it once. - Removed the check in the DMNEngine, and improved in exceptions.py
- The Python Script engines "evaluate" method should accept external methods as an optional argument.
- The Levenshtein function should return a list, not a list coverted to a string.
- For the base excetion handler, don't stuff the name of the task infront of the error, it's passed along as the sender - no need to alter the message.
…fitions ('End Event' not 'Default End Event')
2) MultInstance functions as a mixin, and should not overwrite the spec_type, a releating User Task is stil a User Task
3) We implemented "Did you mean ..." twice - and with the latest changes to the PythonScriptEngine.py and DMNEngine.py, we can do it once. - Removed the check in the DMNEngine, and improved in exceptions.py
4) The Python Script engines "evaluate" method should accept external methods.
5) The Levenshtein function should return a list, not a list coverted to a string.
6) For the base excetion handler, don't stuff the name of the task infront of the error, it's passed along as the sender - no need to alter the message.
essweine
approved these changes
Oct 7, 2022
burnettk
approved these changes
Oct 7, 2022
1. white space formatting 2. empty except statements 3. camel casing variables (when it doesn't impact serialization) 4. create constants when a string is used multiple times. 5. add comments when methods are completely empty 6. and other minor business
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.