Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saros/E - Google Formatter breaks Eclipse Tooling for externalizing strings #621

Open
srossbach opened this issue Aug 5, 2019 · 1 comment
Open

Saros/E - Google Formatter breaks Eclipse Tooling for externalizing strings #621

srossbach opened this issue Aug 5, 2019 · 1 comment
Labels
Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) Type: Bug Issue that describes an unintended behavior of Saros

Comments

@srossbach
Copy link
Contributor

image
@srossbach srossbach added the Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) label Aug 5, 2019
@srossbach srossbach assigned m273d15 and unassigned m273d15 Aug 5, 2019
@srossbach
Copy link
Contributor Author

srossbach commented Aug 5, 2019 •
edited
Loading

Seems the Google Java Formatter google/google-java-format#361 format the code in such a way that the Eclipse Tooling for Externalize Strings has problems to determine if a string was already marked as "do not externalize".

This makes the whole tooling almost non usable as it will show you non externalized strings over and over again.

@srossbach srossbach added the Type: Bug Issue that describes an unintended behavior of Saros label Aug 5, 2019
@srossbach srossbach changed the title Saros/E - Externalize Strings Saros/E - Google Formatter breaks Eclipse Tooling for externalizing strings Aug 5, 2019
@m273d15 m273d15 removed their assignment Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Eclipse Issue affecting Saros for Eclipse (Saros/E) Type: Bug Issue that describes an unintended behavior of Saros
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m273d15 @srossbach