Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//$NON-NLS-x$ notation broken in Eclipse formatter 1.6 #361

Open
JackPGreen opened this issue Apr 5, 2019 · 3 comments
Open

//$NON-NLS-x$ notation broken in Eclipse formatter 1.6 #361

JackPGreen opened this issue Apr 5, 2019 · 3 comments

Comments

@JackPGreen
Copy link

JackPGreen commented Apr 5, 2019

Take the simple class:

public class test {
  public static void main(final String[] args) {
    String myString = "someString"; //$NON-NLS-1$
  }
}

Using "google-java-format-eclipse-plugin_1.6.0.jar", when formatted it converts:
//$NON-NLS-1$
To:
// $NON-NLS-1$

This is supposed to be fixed in issue #221, but doesn't appear to be...?

Am I missing something?

@JackPGreen
Copy link
Author

I've tried the 1.7 Eclipse plugin from #331 but this issue is still present.

@cushon
Copy link
Collaborator

cushon commented Dec 19, 2019

I think it was only fixed for cases where the //$NON-NLS-1$ comment appears on its own line.

@JackPGreen
Copy link
Author

This is still a problem in Eclipse plugin version 1.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants