feat: Add support for ESLint v9 #356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this is a duplicate of #353. Please leave this PR open so I can keep both in sync (in the future, instead of opening a duplicate PR, please comment with a link to commits on the existing one, and I can pull them in) |
ljharb
requested changes
Oct 7, 2024
|
|
||
| You'll probably also need to add `--ext .js, .cjs, .mjs` if you're working with one of the new Javascript filename extensions in your project. | ||
|
|
||
| <u>**Note:**</u> ESLint v9 support requires a recent version of Node.JS: `^18.18.0 || ^20.9.0 || >=21.1.0`, as mentionned in the [ESLint documentation](https://eslint.org/docs/latest/use/migrate-to-9.0.0#-nodejs--v1818-v19-are-no-longer-supported). |
There was a problem hiding this comment.
Suggested change
| <u>**Note:**</u> ESLint v9 support requires a recent version of Node.JS: `^18.18.0 || ^20.9.0 || >=21.1.0`, as mentionned in the [ESLint documentation](https://eslint.org/docs/latest/use/migrate-to-9.0.0#-nodejs--v1818-v19-are-no-longer-supported). | |
| <u>**Note:**</u> ESLint v9 support requires a recent version of Node.JS: `^18.18.0 || ^20.9.0 || >=21.1.0`, as mentioned in the [ESLint documentation](https://eslint.org/docs/latest/use/migrate-to-9.0.0#-nodejs--v1818-v19-are-no-longer-supported). |
| @@ -49,8 +49,9 @@ | |||
| "codecov": "^2.3.1", | |||
| "commitizen": "^2.10.1", | |||
| "create-require": "^1.1.1", | |||
| "cross-env": "^7.0.3", | |||
There was a problem hiding this comment.
unfortunately we support 10.12, and cross-env 7 requires 10.14. we can use v6 tho.
Suggested change
| "cross-env": "^7.0.3", | |
| "cross-env": "^6.0.3", |
14 tasks
|
I believe this is now obviated by #353. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuing the flat config support in v9 #351
LegacyESLintclass when it is defined^18.18.0 || ^20.9.0 || >=21.1.0.eslintignorebyignorePatternsat the root level of the project to remove warning message in the tests