Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(errors): expose all identifiers in an enum #161

Merged
merged 1 commit into from
Feb 6, 2021
Merged

feat(errors): expose all identifiers in an enum #161

merged 1 commit into from
Feb 6, 2021

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Feb 6, 2021

No description provided.

@kyranet kyranet requested a review from favna as a code owner February 6, 2021 10:25
@kyranet kyranet requested a review from a team February 6, 2021 10:25
@kyranet kyranet force-pushed the feat/expose-all-built-in-identifiers branch from 2b4a0ad to 24b9df0 Compare February 6, 2021 10:35
favna
favna requested changes Feb 6, 2021
View reviewed changes
src/arguments/CoreBoolean.ts Show resolved Hide resolved
src/arguments/CoreCategoryChannel.ts Show resolved Hide resolved
src/arguments/CoreChannel.ts Show resolved Hide resolved
src/arguments/CoreDMChannel.ts Show resolved Hide resolved
src/arguments/CoreDate.ts Show resolved Hide resolved
src/arguments/CoreNumber.ts Show resolved Hide resolved
src/arguments/CoreRole.ts Show resolved Hide resolved
src/arguments/CoreTextChannel.ts Show resolved Hide resolved
src/arguments/CoreUser.ts Show resolved Hide resolved
src/arguments/CoreVoiceChannel.ts Show resolved Hide resolved
@kyranet kyranet force-pushed the feat/expose-all-built-in-identifiers branch 2 times, most recently from 77aaa6f to 57e180c Compare February 6, 2021 13:26
@kyranet kyranet requested a review from favna February 6, 2021 13:27
@kyranet kyranet force-pushed the feat/expose-all-built-in-identifiers branch 2 times, most recently from 34eb77d to 533cc9f Compare February 6, 2021 13:38
favna
favna previously approved these changes Feb 6, 2021
View reviewed changes
vladfrangu
vladfrangu requested changes Feb 6, 2021
View reviewed changes
src/arguments/CoreString.ts Outdated Show resolved Hide resolved
src/arguments/CoreString.ts Outdated Show resolved Hide resolved
@kyranet kyranet force-pushed the feat/expose-all-built-in-identifiers branch from 533cc9f to 6de3d46 Compare February 6, 2021 15:16
@kyranet kyranet requested review from vladfrangu and favna February 6, 2021 15:17
vladfrangu
vladfrangu requested changes Feb 6, 2021
View reviewed changes
src/arguments/CoreString.ts Outdated Show resolved Hide resolved
src/arguments/CoreString.ts Outdated Show resolved Hide resolved
@kyranet
feat(errors): expose all identifiers in an enum
3165caf 
BREAKING CHANGE: Changed UserError identifier from `'ArgumentBooleanInvalidBoolean'` to `Identifiers.ArgumentBoolean`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentCategoryChannelInvalidChannel'` to `Identifiers.ArgumentCategoryChannel`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentChannelMissingChannel'` to `Identifiers.ArgumentChannel`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentDateInvalidNumber'` to `Identifiers.ArgumentDate`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentDateTooSmall'` to `Identifiers.ArgumentDateTooSmall`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentDateTooBig'` to `Identifiers.ArgumentDateTooBig`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentDMChannelInvalidChannel'` to `Identifiers.ArgumentDMChannel`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentFloatInvalidFloat'` to `Identifiers.ArgumentFloat`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentFloatTooSmall'` to `Identifiers.ArgumentFloatTooSmall`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentFloatTooBig'` to `Identifiers.ArgumentFloatTooBig`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentGuildChannelMissingGuild'` to `Identifiers.ArgumentGuildChannelMissingGuild`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentGuildChannelUnknownChannel'` to `Identifiers.ArgumentGuildChannel`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentHyperlinkInvalidURL'` to `Identifiers.ArgumentHyperlink`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentIntegerInvalidNumber'` to `Identifiers.ArgumentInteger`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentIntegerTooSmall'` to `Identifiers.ArgumentIntegerTooSmall`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentIntegerTooBig'` to `Identifiers.ArgumentIntegerTooBig`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentMemberMissingGuild'` to `Identifiers.ArgumentMemberMissingGuild`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentMemberUnknownMember'` to `Identifiers.ArgumentMember`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentMessageUnknownMessage'` to `Identifiers.Message`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentNewsChannelInvalidChannel'` to `Identifiers.NewsChannel`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentNumberInvalidNumber'` to `Identifiers.Number`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentNumberTooSmall'` to `Identifiers.ArgumentNumberTooSmall`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentNumberTooBig'` to `Identifiers.ArgumentNumberTooBig`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentRoleMissingGuild'` to `Identifiers.ArgumentRoleMissingGuild`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentRoleUnknownRole'` to `Identifiers.Role`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentStringTooShort'` to `Identifiers.ArgumentStringTooShort`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentStringTooLong'` to `Identifiers.ArgumentStringTooLong`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentTextChannelInvalidChannel'` to `Identifiers.TextChannel`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentUserUnknownUser'` to `Identifiers.User`.
BREAKING CHANGE: Changed UserError identifier from `'ArgumentVoiceChannelInvalidChannel'` to `Identifiers.VoiceChannel`.
BREAKING CHANGE: Changed UserError identifier from `'CommandDisabled'` to `Identifiers.CommandDisabled`.
BREAKING CHANGE: Changed UserError identifier from `'UnavailableArgument'` to `Identifiers.ArgsUnavailable`.
BREAKING CHANGE: Changed UserError identifier from `'MissingArguments'` to `Identifiers.ArgsMissing`.
BREAKING CHANGE: Changed UserError identifier from `'Cooldown'` to `Identifiers.PreconditionCooldown`.
BREAKING CHANGE: Changed UserError identifier from `'DMOnly'` to `Identifiers.PreconditionDMOnly`.
BREAKING CHANGE: Changed UserError identifier from `'GuildOnly'` to `Identifiers.PreconditionGuildOnly`.
BREAKING CHANGE: Changed UserError identifier from `'NSFW'` to `Identifiers.PreconditionNSFW`.
BREAKING CHANGE: Changed UserError identifier from `'Permissions'` to `Identifiers.PreconditionPermissions`.
@kyranet kyranet force-pushed the feat/expose-all-built-in-identifiers branch from 6de3d46 to 3165caf Compare February 6, 2021 15:31
@kyranet kyranet requested a review from vladfrangu February 6, 2021 15:34
@kyranet kyranet merged commit 3371f35 into main Feb 6, 2021
@kyranet kyranet deleted the feat/expose-all-built-in-identifiers branch February 6, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@favna favna favna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyranet @favna @vladfrangu