Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preconditions): make options optional #155

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Conversation

Stitch07
Copy link
Contributor

@Stitch07 Stitch07 commented Feb 4, 2021

Since identifiers default to the Precondition's name, you don't need any options if you have no context. Now, the only way to do that is this.error({}) which feels clunky.

@kyranet kyranet merged commit ecc5323 into main Feb 4, 2021
@kyranet kyranet deleted the fix/precondition-errors branch February 4, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants