Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(args): add Args#finished #125

Merged
merged 3 commits into from
Jan 3, 2021
Merged

feat(args): add Args#finished #125

merged 3 commits into from
Jan 3, 2021

Conversation

Stitch07
Copy link
Contributor

@Stitch07 Stitch07 commented Jan 3, 2021

No description provided.

@Stitch07 Stitch07 requested review from favna and kyranet as code owners January 3, 2021 20:00
@favna favna requested review from vladfrangu and a team January 3, 2021 20:19
Nytelife26
Nytelife26 approved these changes Jan 3, 2021
View reviewed changes
Copy link
Contributor

@Nytelife26 Nytelife26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative option could be to make the parser accessible from outside the Args handler, to prevent the need for future convenience accessors and allow more flexibility? But for now, LGTM.

@favna favna enabled auto-merge (squash) January 3, 2021 22:15
@kyranet kyranet disabled auto-merge January 3, 2021 22:32
@kyranet kyranet merged commit 36e0a1f into sapphiredev:main Jan 3, 2021
@Stitch07 Stitch07 deleted the feat/args.finished branch January 30, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet approved these changes

@Nytelife26 Nytelife26 Nytelife26 approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@favna favna favna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Stitch07 @favna @vladfrangu @Nytelife26 @kyranet @Soumil-07