fix(ApplicationCommandRegistries): registries are empty sometimes

src/lib/structures/CommandStore.ts

@@ -1,5 +1,5 @@
 import { AliasStore } from '@sapphire/pieces';
-import { emitRegistryError } from '../utils/application-commands/emitRegistryError';
+import { registries } from '../utils/application-commands/ApplicationCommandRegistries';
 import { getNeededRegistryParameters } from '../utils/application-commands/getNeededParameters';
 import { Command } from './Command';
 
@@ -21,16 +21,6 @@ export class CommandStore extends AliasStore<Command> {
 		return [...categories] as string[];
 	}
 
-	public override async insert(piece: Command) {
-		try {
-			await piece.registerApplicationCommands(piece.applicationCommandRegistry);
-		} catch (error) {
-			emitRegistryError(error, piece);
-		}
-
-		return super.insert(piece);
-	}
-
 	public override unload(name: string | Command) {
 		const piece = this.resolve(name);
 
@@ -49,10 +39,8 @@ export class CommandStore extends AliasStore<Command> {
 			}
 		}
 
-		// Reset the registry's contents
-		piece.applicationCommandRegistry.chatInputCommands.clear();
-		piece.applicationCommandRegistry.contextMenuCommands.clear();
-		piece.applicationCommandRegistry['apiCalls'].length = 0;
+		// Remove the registry from the application command registries
+		registries.delete(piece.name);
 
 		return super.unload(name);
 	}

src/lib/utils/application-commands/ApplicationCommandRegistries.ts

@@ -1,6 +1,7 @@
 import { container } from '@sapphire/pieces';
 import { RegisterBehavior } from '../../types/Enums';
 import { ApplicationCommandRegistry } from './ApplicationCommandRegistry';
+import { emitRegistryError } from './emitRegistryError';
 import { getNeededRegistryParameters } from './getNeededParameters';
 
 export let defaultBehaviorWhenNotIdentical = RegisterBehavior.LogToConsole;
@@ -40,6 +41,14 @@ export function getDefaultBehaviorWhenNotIdentical() {
 export async function handleRegistryAPICalls() {
 	const commandStore = container.stores.get('commands');
 
+	for (const command of commandStore.values()) {
+		try {
+			await command.registerApplicationCommands(command.applicationCommandRegistry);
+		} catch (error) {
+			emitRegistryError(error, command);
+		}
+	}
+
 	const { applicationCommands, globalCommands, guildCommands } = await getNeededRegistryParameters();
 
 	for (const registry of registries.values()) {