Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kube-monitoring-compute-pluginpreset #7307

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Add kube-monitoring-compute-pluginpreset #7307

merged 2 commits into from
Oct 25, 2024
+62 −34

Conversation

max-len
Copy link
Member

@max-len max-len commented Oct 23, 2024

No description provided.

richardtief
richardtief requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@richardtief richardtief left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated comment.

richardtief
richardtief requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@richardtief richardtief left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved.

system/greenhouse-ccloud/templates/kube-monitoring-compute-pluginpreset.yaml Outdated Show resolved Hide resolved
@auhlig
Copy link
Member

auhlig commented Oct 25, 2024

For now, I solved it with the existing kube-monitoring pluginpreset. An additional kube-monitoring-compute would only be necessary if its configuration significantly deviates from the kube-monitoring one

richardtief
richardtief approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@richardtief richardtief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PluginPreset accordingly.

@richardtief richardtief merged commit f57ccd0 into sapcc:master Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardtief richardtief richardtief approved these changes

@auhlig auhlig Awaiting requested review from auhlig auhlig is a code owner

@IvoGoman IvoGoman Awaiting requested review from IvoGoman IvoGoman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-len @auhlig @richardtief