-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mariadb): rename metric in alert #5339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(mariadb): rename metric in alert mysql_info_schema_threads_seconds > mysql_info_schema_processlist_seconds see prometheus/mysqld_exporter#603
b3d976a
to
dcf8048
Compare
viktor-kovacs
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! THNX
grandchild
added a commit
that referenced
this pull request
Oct 24, 2023
Enable `set_main_container` config for mariadb chart, giving the mariadb container 75% of its pod's resources. mariadb chart changes (newest-to-oldest): - Rolling back Security Patches 10.5.21 to 10.5.17 - Enable VPA for mariadb container (#5443) - metric was renamed (#5339) - Security Patches upgrade to 10.5.21 - Mariadb upgrade from 10.5.17 to 10.5.21 - mysqld-exporter upgrade from v0.12.1 to v0.14.0 - improve MariaDBNotReady alert - updates backupv2 base image (#5128) - use non-deprecated topology labels (#5087) - explicitly add some namespace metadata - version bump for slow log alert fix - fixes slow_query log setting in backup tool (#4787) - Backup Slow log fix - Security Patches upgrade to 10.5.17
grandchild
added a commit
that referenced
this pull request
Oct 24, 2023
Enable `set_main_container` config for mariadb chart, giving the mariadb container 75% of its pod's resources. mariadb chart changes (newest-to-oldest): - Rolling back Security Patches 10.5.21 to 10.5.17 - Enable VPA for mariadb container (#5443) - metric was renamed (#5339) - Security Patches upgrade to 10.5.21 - Mariadb upgrade from 10.5.17 to 10.5.21 - mysqld-exporter upgrade from v0.12.1 to v0.14.0 - improve MariaDBNotReady alert - updates backupv2 base image (#5128) - use non-deprecated topology labels (#5087) - explicitly add some namespace metadata - version bump for slow log alert fix - fixes slow_query log setting in backup tool (#4787) - Backup Slow log fix - Security Patches upgrade to 10.5.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric
mysql_info_schema_threads_seconds
has been renamed tomysql_info_schema_processlist_seconds
with exporter v0.14.0 see prometheus/mysqld_exporter#603