Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection: Add collection dependency for community.general #808

Conversation

berndfinger
Copy link
Member

for fixing the galaxy-importer error "syntax-check[unknown-module]: couldn'''t resolve module/action '''community.general.zypper'''"

for fixing the galaxy-importer error "syntax-check[unknown-module]: couldn'\''t resolve module/action '\''community.general.zypper'\''"

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Copy link
Member

@Wabri Wabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Necessary dependency. I'm not happy about it, but we need to do this for the foreseeable future.

@berndfinger berndfinger merged commit 01b6241 into sap-linuxlab:dev Jul 17, 2024
2 of 3 checks passed
@berndfinger berndfinger deleted the issue-716-add-community-general-collection-dependency branch July 17, 2024 15:09
@berndfinger
Copy link
Member Author

FYI: This modification caused error messages of type:

ERROR    [WARNING]: Collection at '(directory)' does not have a MANIFEST.json file, nor has it galaxy.yml: cannot detect version.

and:

ERROR! Unexpected Exception, this is probably a bug: Non integer values in LooseVersion ('latest')

as the last line, when running ansible-lint locally.

I could avoid this error by running:

ansible-lint --project-dir .

instead.

@Wabri
Copy link
Member

Wabri commented Jul 17, 2024

Why didn't the ci/cd throw this error?

@berndfinger
Copy link
Member Author

Why didn't the ci/cd throw this error?

Good question. Here's another one: Why, even after merging this PR, does the galaxy-importer still show the same syntax-check[unknown-module]: couldn'\''t resolve module/action '\''community.general.zypper'\'' error message? See here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants