Merge dev to main for release 1.2.1 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sap_install_media_detect and sap_swpm: minor patches
sap_netweaver_preconfigure: Solve issue #304
Solve issue 306 (avoid the `nobest` parameter in the `dnf` module)
Collection: Prepare for v1.2.1
sean-freeman
approved these changes
Jan 25, 2023
ja9fuchs
reviewed
Jan 25, 2023
| ansible.builtin.debug: | ||
| msg: "INFO: Not checking for link {{ sap_netweaver_preconfigure_rpath }}/libstdc++.so.6 - file /opt/rh/SAP/lib64/compat-sap-c++-10.so does not exist on this system." | ||
| when: not __sap_netweaver_preconfigure_register_stat_compat_sap_cpp.stat.exists | ||
|
|
||
| - name: Get info about file "{{ sap_netweaver_preconfigure_rpath }}/libstdc++.so.6" |
There was a problem hiding this comment.
Suggesting improvement:
Use quotes around the entire task name, do not start in the middle of the name.
ja9fuchs
approved these changes
Jan 25, 2023
sap_netweaver_preconfigure: Surround absolute file names with single quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.