Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use glitchtip instead of sentry #4400

Closed
wants to merge 1 commit into from
Closed

Conversation

tspenov
Copy link
Contributor

@tspenov tspenov commented Sep 27, 2024

Changes

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

@@ -46,6 +46,10 @@ defmodule Sanbase.Application do
# Note: Sentry.LoggerBackend now allows to send non-exception errors to sentry, too.
# This is not enabled yet.
{:ok, _} = Logger.add_backend(Sentry.LoggerBackend)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger's backend is fulfilling the same purpose as Erlang's :logger handlers, so we need to leave only the :logger.add_handler(...) part.

Also, in the Sentry dependency docs we see this:
image

@tspenov tspenov closed this Oct 15, 2024
@tspenov tspenov deleted the use-glitchtip-instead-sentry branch October 15, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants