Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed of query used in available_metrics #3888

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

IvanIvanoff
Copy link
Member

@IvanIvanoff IvanIvanoff commented Aug 11, 2023

Changes

The improved query is one of the queries used to compute available_slugs. If it is too slow, the whole computation of available_slugs fails. available_slugs is cached in the RehydratingCache which will then start to try to compute it over and over again (for all queried slugs), which puts a lot of pressure on Clickhouse, slowing all the API queries.

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

@IvanIvanoff IvanIvanoff merged commit aaf1abb into master Aug 11, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the improve-query-speed branch August 11, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant