fix(tooltip): regression where hover to open stops working

[stipsan]

Properly fixes the hover regressions introduced in #1369, causing studio tests to fail, which #1370 attempted to resolve but didn't.

Here's a video demonstrating that moving between tooltips last worked before #1369 merged, how it stopped working, and finally that it's working again in this PR:

tooltip.fix.mov

The root cause is that I didn't understand the significance of eagerly removing the mousemove event listener (line 303) in the original code:

ui/src/core/primitives/tooltip/tooltip.tsx

Lines 288 to 312 in 3351fa2

	// Detect whether the mouse is moving outside of the reference element. This is sometimes
	// necessary, because the tooltip might not always close as it should (e.g. when clicking
	// the reference element triggers a CPU-heavy operation.)
	useEffect(() => {
	if (!showTooltip) return
	function handleWindowMouseMove(event: MouseEvent) {
	if (!referenceElement) return
	const isHoveringReference =
	referenceElement === event.target ||
	(event.target instanceof Node && referenceElement.contains(event.target))
	if (!isHoveringReference) {
	handleIsOpenChange(false)
	window.removeEventListener('mousemove', handleWindowMouseMove)
	}
	}
	window.addEventListener('mousemove', handleWindowMouseMove)
	return () => {
	window.removeEventListener('mousemove', handleWindowMouseMove)
	}
	}, [showTooltip, referenceElement, handleIsOpenChange])

and assumed it was there by mistake.
It's clearly very intentional and I've added a comment so that others don't make the same assumption in the future.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sanity-ui-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 11, 2024 2:25pm
sanity-ui-workshop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 11, 2024 2:25pm