-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(structure): add support to force a version for the pane provider #8176
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Jan 3, 2025 3:59 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Fri, 03 Jan 2025 16:02:13 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! forcedVersion
is clear and descriptive to me
Description
Sanity assist
uses a document defined as liveEdit so not using the global version is not enough, we need to force the published one.So, this removes the
matchGlobalVersion
prop and changes it for aforcedVersion
allowing the user to define which version to link the paneProvider to.See the use for when we have a history item selected.
Assist should do the folllowing:
What to review
Is there a better naming we could use for the
forcedVersion
?Testing
Notes for release