Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): remove unused PerspectiveBadge component #8152

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

pedrobonamin
Copy link
Contributor

Description

Removes PerspectiveBadge which is unused

What to review

Testing

Notes for release

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 9:34am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 9:34am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 9:34am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 9:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 2, 2025 9:34am

@pedrobonamin pedrobonamin marked this pull request as ready for review January 2, 2025 09:21
@pedrobonamin pedrobonamin requested a review from a team as a code owner January 2, 2025 09:21
@pedrobonamin pedrobonamin requested review from ricokahler and removed request for a team and ricokahler January 2, 2025 09:21
Copy link
Contributor

github-actions bot commented Jan 2, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Component Testing Report Updated Jan 2, 2025 9:31 AM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 18s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 26s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 37s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 12s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 2, 2025

⚡️ Editor Performance Report

Updated Thu, 02 Jan 2025 09:32:54 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
recipe (name) 57.1 efps (18ms) 34.5 efps (29ms) +12ms (+65.7%) 🔴
recipe (description) 64.5 efps (16ms) 37.0 efps (27ms) +12ms (+74.2%) 🔴
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.2 efps (52ms) 7.9 efps (126ms) +74ms (+142.3%) 🔴
synthetic (string inside object) 19.6 efps (51ms) 8.0 efps (125ms) +74ms (+145.1%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
recipe (name) 18ms 20ms 22ms 51ms 0ms 6.4s
recipe (description) 16ms 17ms 20ms 34ms 0ms 4.2s
recipe (instructions) 5ms 6ms 9ms 11ms 0ms 3.0s
synthetic (title) 52ms 55ms 58ms 300ms 466ms 12.6s
synthetic (string inside object) 51ms 55ms 60ms 274ms 196ms 8.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
recipe (name) 29ms 32ms 35ms 46ms 0ms 7.6s
recipe (description) 27ms 29ms 31ms 50ms 7ms 5.4s
recipe (instructions) 5ms 7ms 7ms 24ms 0ms 3.0s
synthetic (title) 126ms 134ms 142ms 895ms 6245ms 20.9s
synthetic (string inside object) 125ms 136ms 157ms 657ms 5728ms 15.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin merged commit 5ff3aae into corel Jan 2, 2025
54 of 56 checks passed
@pedrobonamin pedrobonamin deleted the corel-remove-unused branch January 2, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant