-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): put back select button for single-asset source #7030
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Jun 26, 2024 8:37 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it manually and looks good, would be nice to have some sort of unit/component test for this. I see there is a unit test file for ImageInput
but it's skipped/commented so probably not as simple to test I am assuming
Description
Seems like there was a regression in #6930 where the Select/Browse button would not render if there was only a single asset source.
What to review
Does the button show up now for a single asset source?
Testing
I removed the custom asset source so that there would only be one in the test studio, observed the bug, then fixed it.
Notes for release
Fixes a regression that caused the Select button to not appear.