Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): put back select button for single-asset source #7030

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ricokahler
Copy link
Contributor

Description

Seems like there was a regression in #6930 where the Select/Browse button would not render if there was only a single asset source.

What to review

Does the button show up now for a single asset source?

Testing

I removed the custom asset source so that there would only be one in the test studio, observed the bug, then fixed it.

Notes for release

Fixes a regression that caused the Select button to not appear.

@ricokahler ricokahler requested a review from a team as a code owner June 26, 2024 20:24
@ricokahler ricokahler requested review from rexxars and removed request for a team June 26, 2024 20:24
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 8:28pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 8:28pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 8:28pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 8:28pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 8:28pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jun 26, 2024 8:28pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jun 26, 2024 8:37 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 39s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 34s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 16s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 59s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 39s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 21s 20 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 9s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 23s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 16s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 11s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 56s 18 0 0

Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it manually and looks good, would be nice to have some sort of unit/component test for this. I see there is a unit test file for ImageInput but it's skipped/commented so probably not as simple to test I am assuming

@ricokahler ricokahler added this pull request to the merge queue Jun 26, 2024
Merged via the queue into next with commit f96140f Jun 26, 2024
42 checks passed
@ricokahler ricokahler deleted the fix/no-select-button branch June 26, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants