Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structure): don't replace url when navigating back to list after document deletion #6953

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jun 17, 2024

Description

Before the fix in #6923 got merged, when deleting a document, you could always hit the back button to get back to the newly deleted document, and there you’d be given a way to undo/restore it.

Now after this fix, if you delete a document you can no longer hit the back button to recover a deleted document if you realise you made a mistake (unless you remember the id, which you probably don’t). This is not great, and we want to leave a history entry in this case so you navigate back.

What to review

Deleting a document should allow you to navigate back to restore it.

Notes for release

n/a since the changes in #6923 has not been released yet

@bjoerge bjoerge requested a review from a team as a code owner June 17, 2024 10:59
@bjoerge bjoerge requested review from rexxars and removed request for a team June 17, 2024 10:59
Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 11:02am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 11:02am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 11:02am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 11:02am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 11:02am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jun 17, 2024 11:02am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jun 17, 2024 11:09 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 37s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 13s 20 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 29s 12 0 0

@bjoerge bjoerge requested a review from rdunk June 18, 2024 12:04
@bjoerge bjoerge changed the title fix(structure): don't replace url when navigating back to list after … fix(structure): don't replace url when navigating back to list after document deletion Jun 18, 2024
Copy link
Member

@rdunk rdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I think this makes a lot of sense.

@bjoerge bjoerge added this pull request to the merge queue Jun 18, 2024
Merged via the queue into next with commit f662ae2 Jun 18, 2024
41 of 43 checks passed
@bjoerge bjoerge deleted the sdx-1411 branch June 18, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants