-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add support for 'full' array insert menu #6763
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Jun 4, 2024 7:36 AM (UTC)
|
christianhg
force-pushed
the
feat-full-insert-menu
branch
from
May 24, 2024 16:36
4e175a2
to
79ecbd5
Compare
christianhg
force-pushed
the
chore-improve-page-building-studio
branch
from
May 27, 2024 12:03
6575ca8
to
f941566
Compare
christianhg
force-pushed
the
feat-full-insert-menu
branch
from
May 27, 2024 12:17
79ecbd5
to
2caae78
Compare
christianhg
force-pushed
the
feat-full-insert-menu
branch
from
June 3, 2024 13:01
42c1ee8
to
b1ddce0
Compare
I need the same logic in a new component in a subsequent PR so I'm abstracting it beforehand. `||` and `&&` have been changed to `??` and `?:` to avoid returning `| false` from the function. Now, it just returns `ComponentType | undefined`.
christianhg
force-pushed
the
feat-full-insert-menu
branch
from
June 4, 2024 07:26
b1ddce0
to
be6441a
Compare
christianhg
changed the base branch from
next
to
chore-schema-type-icon-helper-function
June 4, 2024 07:26
christianhg
force-pushed
the
chore-schema-type-icon-helper-function
branch
2 times, most recently
from
June 4, 2024 17:41
676b508
to
0c3693e
Compare
Closing this in favour of #6853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Maybe this needs to go behind some sort of feature flag before merging. I just haven't figured out yet what the best mechanism is for that.
Description
A new
insertMenu
array option that allows you to pick afull
layout along with optional grouping.If you leave out
groups
in the config, then they are left out of the UI as well:You can use both the groups and the free text field to filter item types in the array:
And you can toggle a grid view on the insert menu (still a WIP):
What to review
FieldGroupTabs
to render the group tabs?Testing
No automated tests added so far, but we can look into that before merging.
Known issues
Notes for release