feat(vanity): add support for vanity name in url #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, is there anything blocking this PR from getting merged? I need this for my project and I am available to help if needed cc @rexxars |
rexxars
approved these changes
Oct 31, 2024
|
Apologies for the delay, this is great! Thank you so much @Isissss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Add method to builder to add vanity name
Description:
Adds vanity name to the image builder by setting the vanityName() method
Reason:
Clear and descriptive file names are good for SEO purposes. Seemed useful to add to this package so you don't need extra logic to add it yourself.
Related issue: #40