Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warnings from styled-components on language input render #112

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Dec 14, 2024

A large number of warnings were being printed because props were being spread onto the <Select> component that it did not support. This PR is more careful about what it passes on, and also adds a few missing attributes, such as id and aria-describedby.

@rexxars rexxars requested review from a team, snorrees and stipsan December 14, 2024 01:24
@stipsan stipsan merged commit 4c71607 into main Dec 16, 2024
10 checks passed
@stipsan stipsan deleted the fix/language-input-warnings branch December 16, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants