refactor(test): cleanup observable tests #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
approved these changes
Jan 3, 2025
bjoerge
commented
Jan 3, 2025
| @@ -2600,7 +2576,7 @@ describe('client', async () => { | |||
| 'data: {"listenerName":"LGFXwOqrf1GHawAjZRnhd6"}', | |||
| '', | |||
| 'event: mutation', | |||
| `data: ${JSON.stringify({document: doc})}`, | |||
| `data: ${JSON.stringify({result: doc})}`, | |||
There was a problem hiding this comment.
this aligns with mutation events from /listen endpoint returning result, not document
| @@ -140,6 +116,37 @@ describe.skipIf(typeof EdgeRuntime === 'string' || typeof document !== 'undefine | |||
| } | |||
| }) | |||
|
|
|||
| test('sends last-event-id header when reconnecting', async () => { | |||
There was a problem hiding this comment.
buried lede, perhaps, but this change is in a separate commit, so we might want merge with rebase to keep this as a separate item in the commit history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the tests for client.listen and client.live, making them less verbose and (hopefully) a bit easier to follow.
Also added a test to assert that the client sends
last-event-idheader in case of a disconnect.Also fixed a couple of warnings that was issued during test runs due to lack of awaiting (or returning) promises at the end of a few tests:
++ a couple of other minor improvements