Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing listenerName property on welcome event #894

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: add missing listenerName property on welcome event #894

merged 1 commit into from
Oct 3, 2024

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Oct 3, 2024

The listenerName property is handy to debug certain listener related issues, but was not part of the typings.

binoy14
binoy14 approved these changes Oct 3, 2024
View reviewed changes
Copy link

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@rexxars rexxars added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 6173089 Oct 3, 2024
15 checks passed
@rexxars rexxars deleted the fix/welcome-event-name branch October 3, 2024 20:34
@ecospark ecospark bot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binoy14 binoy14 binoy14 approved these changes

@ricokahler ricokahler ricokahler approved these changes

@bjoerge bjoerge Awaiting requested review from bjoerge

@juice49 juice49 Awaiting requested review from juice49

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rexxars @binoy14 @ricokahler