Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't try to serialize list values if list is not an array #11

Merged
merged 1 commit into from
Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions plugin/src/schemas/serialize/serializeSchema.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,33 @@ describe('serializeSchema', () => {
])
})

test('should not try to serialize list values if list values are not an array', () => {
const schema = Schema.compile({
name: 'test',
types: [
defineType({
type: 'array',
name: 'list',
of: [{type: 'string'}],
options: {
list: new Promise(() => {}) as any, // Type usually only accepts array, but some plugins might use other types
},
}),
],
})

const serializedTypes = serializeSchema(schema, {leanFormat: true})

expect(serializedTypes).toEqual([
{
name: 'list',
type: 'array',
of: [{type: 'string', name: 'string', title: 'String'}],
values: undefined,
},
])
})

test('should exclude truthy hidden and readonly', () => {
const schema = Schema.compile({
name: 'test',
Expand Down
2 changes: 1 addition & 1 deletion plugin/src/schemas/serialize/serializeSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function getBaseFields(
imagePromptField: imagePromptField,
}
: undefined,
values: type?.options?.list
values: Array.isArray(type?.options?.list)
? type?.options?.list.map((v: string | {value: string; title: string}) =>
typeof v === 'string' ? v : v.value ?? `${v.title}`
)
Expand Down