Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #24 #25

Closed
wants to merge 2 commits into from
Closed

Fix #24 #25

wants to merge 2 commits into from

Conversation

lixiaoqity
Copy link

Create a new file to store data. Please check if it is ok. Thanks.

@uwaseem
Copy link
Contributor

uwaseem commented Oct 19, 2020

I'm not sure of the direction the author wants to take, but what are your thoughts on moving this into 2 separate files?
They could both live within the data folder, 1 being called desserts.js and the other adjectives.js.

Current implementation seems like the same as before, still cluttered only moved to a different file. I don't see much added value there besides separation of logic from data.
My proposal on the other hand would introduce clear separation between data types. In the future, it will be much clearer which files to change when we want to add specific things.

@lixiaoqity
Copy link
Author

Yes, two separated files are more readable. I have changed it.

@sanijalal sanijalal closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants