-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path parameter description #189
Path parameter description #189
Conversation
I'd love to help, but to be 100% honest, I am only here to help with admin functions. I know very little of the source code here, and am not the one to review and approve the PR. Let's wait to see what @chenjr0719 has to say before I try and look it over. |
bump |
I like the idea but I think the current method of automatically parsing the path parameters is too valuable to lose, If this PR was changed to make the manually decorated parameter annotation update the default value with the description instead of overwrite it I think it could be useful, but since the PR is half a year old I think it would be better to close this PR @ahopkins |
@artcg I just added some improvements. They would save current path param autodetect and override it with decorator. |
Cool thanks for the quick change :) I thought this was inactive but great that we can still add it I think that the |
Closes #188
@chenjr0719 Hello! Answering on feature request #188 May be defining path parameters in consume decorator instead of getting from route parameters is a better idea? Explicit is better than implicit :)