-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for type hinting-based docs #129
Conversation
I acknowledge there aren't tests related to this kind of feature throughout the current codebase. In a future PR, I can work on adding tests to the object serialization. |
@viniciusd Sorry for the delay. About the conflict, please solve it. Maybe you can put the example at here. And, I think it is better to add test in this PR or the code coverage might decrease after merge this PR. |
…into huge-success-master
Huge success master
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 95.54% 95.56% +0.01%
==========================================
Files 4 4
Lines 449 451 +2
Branches 95 95
==========================================
+ Hits 429 431 +2
Misses 6 6
Partials 14 14
Continue to review full report at Codecov.
|
Thanks for the feedback! Gonna add the example to the docs |
Sorry for the delay, got pushed back by a few other tasks. Added docs to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Incrementally addresses #128
A working example that fully works after these changes: