Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub Actions CI #50

Merged
merged 5 commits into from
Mar 31, 2021
Merged

Use GitHub Actions CI #50

merged 5 commits into from
Mar 31, 2021

Conversation

rlaphoenix
Copy link
Collaborator

@rlaphoenix rlaphoenix commented Mar 29, 2021 •
edited
Loading

Fixes: #49

@rlaphoenix
Copy link
Collaborator Author

rlaphoenix commented Mar 29, 2021 •
edited
Loading

I should note I forgot this project intends to keep support for Python 2.6+, the Build Status Workflow file and the Badge needs to be updated to reflect that.

Edit: New commit made to try and solve this. Any ideas or suggestions let me know.

@rlaphoenix
Use 2.7,3.x versions for Build Status
f9cc52c 
 2.6 and 2.8 isn't available. The Build Status Badge will assume 2.6+ is works if this passes. I don't think there's any smoother solution without diving into dodgy 3rd party GitHub actions.
@rlaphoenix
Merge branch 'master' into patch-5
edd2441
sangwonl
sangwonl approved these changes Mar 30, 2021
View reviewed changes
Copy link
Owner

@sangwonl sangwonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

BTW, is there any way to test action running before merge? I already added pypi secrets in this repository.

@rlaphoenix
Copy link
Collaborator Author

Thanks, LGTM 👍

BTW, is there any way to test action running before merge? I already added pypi secrets in this repository.

I dont think so, but this is basically the same data I use in my own repo's so it should be fine

@sangwonl sangwonl merged commit a683b2e into sangwonl:master Mar 31, 2021
@rlaphoenix rlaphoenix deleted the patch-5 branch March 31, 2021 20:07
masantiago pushed a commit to masantiago/python-mpegdash that referenced this pull request Aug 17, 2021
@pmarsi @davemevans
@sangwonl @bvc3at @thenewguy @Jayapraveen @rlaphoenix
Feature/update original fork (#4)
dc409f5 
* Add UTCTiming support

* Add messageData attribute to Event

* Add method to output mpd as a string, and associated test (sangwonl#22)

* Add method to output mpd as a string, and associated test

* Add debugging option in test to see whats happening on Python2.6

* provide own xml prettyprint work round bug in minidom 2.6

* import xml_utils correctly

* Rename xml_utils to something more sensible

* Fix sangwonl#24 - support elements which only contain basic text contents

* Fix sangwonl#25 - use correct case for xsboolean (sangwonl#26)

* Set release version to 0.2.0

change repository for maintenance

* Update README.md

* Fix travis and readme as restructuredtext

* Support non-standard label attribute

Fix sangwonl#32

* clarifies profile vs profiles (sangwonl#37)

* clarifies profile vs profiles

* added profiles attribute to an AdaptationSet

* moved AdaptationSet @profiles for mergability

* Added @selectionPriority to AdaptationSet (sangwonl#35)

* added selection priority to AdaptationSet

* added selectionPriority to first AdaptationSet for identity test

* Add KID attribute to the Descriptor class (sangwonl#38)

Added the KID attribute to the Descriptor class to identify KID in the manifests of DRM encrypted content.

* Improve ignored files and folders (sangwonl#42)

This has the previous ignores and the common ones provided by GitHub.

I also added in the JetBrains project settings ignore.

* Dont use a Bare except on urllib import (sangwonl#43)

* Replace single char re alternation with char class (sangwonl#44)

* Use ImportError, Swap unittest import order (sangwonl#46)

These are swapped since unittest2 is intended to be used if you're on Python 2. More people will be using Python 3 at this point so it's best to import the Python 3 module and if unable to, it will use the backport.

Most people will be using Python 3 so this will also speed things up somewhat as one less unnecessary (almost expected) try catch will be prevented.

* Optimize README (sangwonl#51)

This change cleans up the Markdown to follow typical markdown linting rules (think of it as following PEP 8 for Markdown).

I also added a License Badge, and a section at the bottom.

* Prettyprinter clean up, typos, redundancy (sangwonl#45)

* Prettyprinter clean up, typos, redundancy

Spacing, Unnecessary Lines, Typos, Unnecessary characters, missing r'' for regex strings and unnecessary character escaping.

* Fix typo in prettyprinter

* Use GitHub Actions CI (sangwonl#50)

* Create Build Status GitHub Actions CI

* Create Release Packager GitHub Actions CI

* Use GitHub Actions CI Build Status Badge

* Use 2.7,3.x versions for Build Status

 2.6 and 2.8 isn't available. The Build Status Badge will assume 2.6+ is works if this passes. I don't think there's any smoother solution without diving into dodgy 3rd party GitHub actions.

* add install requirements

* update install requires

* using temporary if/else for requirements

* parsing datetimes

Co-authored-by: davemevans <dave.evans@m2amedia.tv>
Co-authored-by: Sangwon Lee <gamzabaw@gmail.com>
Co-authored-by: David Evans <5390145+davemevans@users.noreply.github.com>
Co-authored-by: bvc3at <thecapslockman@ya.ru>
Co-authored-by: thenewguy <wgordonw1@gmail.com>
Co-authored-by: Jayapraveen AR <jayapraveen.ar.2015.cse@rajalakshmi.edu.in>
Co-authored-by: PHOENiX <pragma.exe@gmail.com>
Co-authored-by: PHOENiX <rlaphoenix@pm.me>
Co-authored-by: Pedro Martin <p.martin@tvup.media>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangwonl sangwonl sangwonl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable CI
2 participants
@rlaphoenix @sangwonl