-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update security notice #183
Conversation
The Best Practices Badge App suggests we should document what users can expect from our project in terms of security.
Reviewer's Guide by SourceryThis pull request updates the security notice to document the use of the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jmgate - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider including instructions for users who don't want to use
pre-commit
but still want to runflake8-bandit
.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 180 180
Branches 15 15
=========================================
Hits 180 180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The Best Practices Badge App suggests we should document what users can expect from our project in terms of security.
Summary by Sourcery
Chores:
flake8-bandit
pre-commit hook in the security notice.