Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra dimension in waves DataArray #365

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

michaelcdevin
Copy link
Collaborator

Description

Resolves #364. The try/except clause allows for environments with older versions of xarray to still be supported.

Type of PR

  • Bug fix
  • New feature
  • Documentation
  • Other: (specify)

Checklist for PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10218544388

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 94.642%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wecopttool/core.py 2 4 50.0%
Totals Coverage Status
Change from base Build 9895751740: 0.008%
Covered Lines: 2773
Relevant Lines: 2930

💛 - Coveralls

@michaelcdevin michaelcdevin added the bug Something isn't working label Aug 2, 2024
@michaelcdevin michaelcdevin self-assigned this Aug 2, 2024
@michaelcdevin michaelcdevin merged commit aa0fc98 into sandialabs:dev Aug 2, 2024
9 of 10 checks passed
@michaelcdevin michaelcdevin deleted the bug/groupby_dims branch August 2, 2024 21:55
michaelcdevin added a commit that referenced this pull request Aug 2, 2024
* remove realization dimension if it exists (#365)

* Update pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants