Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linkcheck #287

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

michaelcdevin
Copy link
Collaborator

Description

Resolves #286.

Type of PR

  • Bug fix
  • New feature
  • Documentation
  • Other: CI/CD

Checklist for PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6649764870

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 92.524%

Totals Coverage Status
Change from base Build 6536704021: 0.07%
Covered Lines: 2500
Relevant Lines: 2702

💛 - Coveralls

@michaelcdevin michaelcdevin requested review from cmichelenstrofer and removed request for ryancoe October 26, 2023 14:20
@cmichelenstrofer cmichelenstrofer merged commit 882fc5d into sandialabs:main Oct 26, 2023
10 checks passed
@michaelcdevin michaelcdevin deleted the remove_linkcheck branch April 1, 2024 16:11
@ryancoe
Copy link
Collaborator

ryancoe commented Apr 2, 2024

@michaelcdevin - running python build_docs.py still appears to be checking links and just not throwing fatal errors, is that right?

image

def linkcheck():
app = Sphinx(source_dir,
conf_dir,
linkcheck_dir,
doctree_dir,
'linkcheck',
warningiserror=False)
app.build()

@michaelcdevin
Copy link
Collaborator Author

That's correct @ryancoe, the warningiserror=False line results in that behavior

@michaelcdevin michaelcdevin mentioned this pull request Apr 21, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Sphinx linkcheck return warnings instead of errors
4 participants