Cleaner territory estimate display #487
Comments
|
This is a feature that I also greatly desire. In my opinion the territory display in Katrain is a major defect. I really like the shading used in LizGoban which also gives the option to display the certainty of territory possession on a scale of 0 - 10.
|
In my opinion ,the display in LizGoban really a disaster, |
It would be best to give users the option of selecting either territory display mode since it seems that different people have opposing opinions on the merits of these two options. |
This is definitely not going to happen, as I think there's already so many options it's confusing. @milescrawford The clean, shaded view seems potentially better, and it's true I've not revisited this since the very early versions. Do you want to have a go at a PR? |
|
I will take a look at the code, but it's a long way from my usual area of
expertise 🙂
…On Wed, Nov 10, 2021, 11:55 PM Sander Land ***@***.***> wrote:
It would be best to give users the option of selecting either territory
display mode since it seems that different people have opposing opinions on
the merits of these two options.
This is definitely not going to happen, as I think there's already so many
options it's confusing.
@milescrawford <https://github.com/milescrawford> The clean, shaded view
seems potentially better, and it's true I've not revisited this since the
very early versions. Do you want to have a go at a PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#487 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACULE2YZR4TO4DQGJNXFMTTULNZGTANCNFSM5HZIYHBQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
I have something working, but I'm having trouble figuring out how to paint the squares underneath the stones - even when I flip the EDIT: nevermind, I was mistaken. |
|
@milescrawford Thanks for doing this Miles! (Perhaps you can draw on the LizGoban repository or @kaorahi may help.) |
|
After my patch, territory and teaching display look like the attached images. If this looks good to people, I can clean things up, run tests (are there docs on how to run the tests?) and submit a PR. |
|
It looks great to me. Well done Miles! |
|
Okay, a PR's up for folks to discuss/amend. Thanks! |
|
Themable, default 0.7
|
|
@sanderland, has this PR been released? I can't find it in v1.10.1 and it isn't referred to in the manual or amongst the themes. |
It has not, it's only in the 1.11 branch. I see it's been quite a while and will release this month. |
|
Many thanks @sanderland! I know there've been quite a few enhancements made since the last release. Many thanks for your great product!!! |
|
@milescrawford What app is your original screenshot from? I'm gonna use this style myself and should probably have a note acknowledging its origins... thanks. |
|
I believe it's one of the display options in Lizzie:
https://github.com/featurecat/lizzie
…On Sat, Mar 5, 2022, 4:32 AM rooklift ***@***.***> wrote:
@milescrawford <https://github.com/milescrawford> What app is your
original screenshot from? I'm gonna use this style myself and should
probably have a note acknowledging its origins... thanks.
—
Reply to this email directly, view it on GitHub
<#487 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACULE255OPXFKJ6MX364ZY3U6NH5ZANCNFSM5HZIYHBQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Is there an option to switch to the original "dots-on-top view of estimated territory" view? In my opinion, "captured stones" are shown much in a much cleaner way in this "dots-on-top view". Also, personally I think the new view seems to have more "noise" that I have to turn it off by default. |
|
I tend to agree with @Carton, even if I get there is a bit too much option in the app already I really would appreciate to be able to use the old expected territory style (even if it is an option to set in a config file somewhere). |
|
Thirded. Furthermore, I don't see an option to tone down the opacity of the dark / light territory overlay. |
|
I fully agree with @Carton, the new style is hard to see for me. |
|
The opacity is already configurable in themes. It seems possible that the display style could also be made themeable. I would love to review a PR that added this if someone wants to try. |
|
Also, it appears that this is all getting reworked in #555 - for better or worse. |
The dots-on-top view of estimated territory adds lots of unnecessary visual noise to the display. In addition, Katrain puts numbers and dots and other things on top of the stones, which are not compatible with this style. I suggest a contiguous shaded, underneath-stones display, as used by some other analysis programs.
Compare:
The text was updated successfully, but these errors were encountered: