Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use If-Unmodified-Since header instead of If-Match due to issue with strong vs. weak etags #72

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Use If-Unmodified-Since header instead of If-Match due to issue with strong vs. weak etags #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ldp/resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def head
# Delete the resource
def delete
client.delete subject do |req|
req.headers['If-Match'] = get.etag if retrieved_content?
req.headers['If-Unmodified-Since'] = get.last_modified if retrieved_content?
end
end

Expand Down Expand Up @@ -95,7 +95,7 @@ def create &block
def update new_content = nil
new_content ||= content
resp = client.put subject, new_content do |req|
req.headers['If-Match'] = get.etag if retrieved_content?
req.headers['If-Unmodified-Since'] = get.last_modified if retrieved_content?
yield req if block_given?
end
update_cached_get(resp) if retrieved_content?
Expand Down