Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurability to how we extract v3 manifest properties from a record #76

Merged
merged 8 commits into from
Oct 10, 2022

Conversation

kirkkwang
Copy link
Contributor

Prior to this commit:

The description, label, rights, and homepage properties were not configurable and relied on the methods supplied by the #record_property_builder. This made it difficult if an application uses the #abstract instead of #description to populate the summary property.

With this commit:

The above mentioned properties are configurable and fall back to its default when there is no configuration.

@kirkkwang
Copy link
Contributor Author

Seems my attempt at adding a Co-author didn't work.. This was from pairing with Jeremy
Co-authored-by: Jeremy Friesen jeremy.n.friesen@gmail.com

@kirkkwang kirkkwang mentioned this pull request Oct 5, 2022
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting! I think this could work.
The documentation and backwards-compatibility are great!

Before merging I think it would be good to update the README and to use the new pattern in the v2 manifest builder here:

manifest.label = record.to_s
manifest.description = record.description

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for adding this useful new feature!

@cjcolvar cjcolvar merged commit eadc239 into main Oct 10, 2022
@cjcolvar cjcolvar deleted the add-configuration branch October 10, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants