Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type to SearchService and AutocompleteService #initial_attributes #71

Merged
merged 3 commits into from
Oct 3, 2022
Merged

add type to SearchService and AutocompleteService #initial_attributes #71

merged 3 commits into from
Oct 3, 2022

Conversation

kirkkwang
Copy link
Contributor

According to pres 3 specs, there needs to be a type property. Adding this property should satisfy this validation error from https://presentation-validator.iiif.io/

image

  • add type property to SearchService#initial_attributes

cjcolvar
cjcolvar reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
It looks like AutocompleteService needs a type as well. Do you mind adding this as well as checks for the types to the few tests for SearchService and AutocompleteService in manifest_factory_spec.rb?

@kirkkwang
Copy link
Contributor Author

Yes, can do!

@kirkkwang kirkkwang changed the title add type to SearchService#initial_attributes add type to SearchService and AutocompleteService #initial_attributes Oct 3, 2022
cjcolvar
cjcolvar approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cjcolvar cjcolvar merged commit e16557a into main Oct 3, 2022
@cjcolvar cjcolvar deleted the add-type-to-search-service branch October 3, 2022 16:16
@cjcolvar cjcolvar mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirkkwang @cjcolvar