Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation 3.0 Alpha Support #19

Merged
merged 20 commits into from
Apr 26, 2018
Merged

Presentation 3.0 Alpha Support #19

merged 20 commits into from
Apr 26, 2018

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Mar 23, 2018

This PR adds support for IIIF Presentation 3.0 Alpha (as of 3/23/2018). Given that clients which consume the manifest will take time to support 3.0 manifests, the approach taken in this PR is to create a new namespace (V3) that subclasses and overwrites as necessary the existing classes that target 2.0 instead of updating in place. To generate Presentation 3.0 manifests, use the IIIFManifest::V3::ManifestFactory instead of IIIFManifest::ManifestFactory passing the same presenters.

See http://prezi3.iiif.io/api/presentation/3.0 for more details on how the manifests generated will be different than the default V2 manifests.

Other changes in the PR:

  • Explicitly wrapping IIIFCollection in the IIIFManifest module

TODO:

@cjcolvar
Copy link
Member Author

I'd like to get this reviewed and maybe merged prior to the TODO listed above. If the test reveals any issues then new PRs could be created to fix them.

@cjcolvar cjcolvar changed the title [WIP] Presentation 3.0 Alpha Presentation 3.0 Alpha Apr 19, 2018
@cjcolvar cjcolvar changed the title Presentation 3.0 Alpha Presentation 3.0 Alpha Support Apr 19, 2018
@cjcolvar cjcolvar requested review from tpendragon and a user April 19, 2018 18:24
Copy link
Contributor

@tpendragon tpendragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine to me. It's ridiculously complex, but that's largely because of the current patterns in place. I'm excited to see the gem being able to generate V3 manifests in addition to V2!

@cjcolvar cjcolvar merged commit 93fa3c2 into master Apr 26, 2018
@cjcolvar cjcolvar deleted the prezi3 branch April 26, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants